cleanup(GCS+gRPC): compute MD5 hashes directly#6959
Merged
coryan merged 2 commits intogoogleapis:mainfrom Jul 9, 2021
Merged
Conversation
Avoid going through the base64 representation used in the REST protocol, as this requires weaving error handling through many layers.
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6959 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 1284 1284
Lines 114289 114301 +12
=======================================
+ Hits 108099 108113 +14
+ Misses 6190 6188 -2
Continue to review full report at Codecov.
|
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid going through the base64 representation used in the REST protocol,
as this requires weaving error handling through many layers.
Part of the work for #6946
This change is