Skip to content

feat(common): cancel long-running operations#6831

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-common-long-running-cancel-for-realsies
Jun 22, 2021
Merged

feat(common): cancel long-running operations#6831
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-common-long-running-cancel-for-realsies

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jun 22, 2021 •
edited
Loading

This time for realsies, I need to return the future created by
AsyncPollingLoop() because this is where the cancel callback is
initialized.

Part of the work for #6821

This change is Reviewable

@coryan
feat(common): cancel long-running operations
273849f 
This time for realsies, I need to return the future created by
`AsyncPollingLoop()` because this is where the cancel callback is
initialized.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 22, 2021

Google Cloud Build Logs
For commit: 273849f79fa162da4305ad5949f839a3c9a90757

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #6831 (273849f) into main (ddb4e25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6831   +/-   ##
=======================================
  Coverage   95.03%   95.04%           
=======================================
  Files        1264     1264           
  Lines      113278   113316   +38     
=======================================
+ Hits       107654   107698   +44     
+ Misses       5624     5618    -6
Impacted Files Coverage Δ
...ogle/cloud/internal/async_long_running_operation.h 100.00% <100.00%> (ø)
...loud/internal/async_long_running_operation_test.cc 97.69% <100.00%> (+6.68%) ⬆️
google/cloud/internal/async_polling_loop_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.76% <0.00%> (-0.47%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 81.41% <0.00%> (+0.44%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb4e25...273849f. Read the comment docs.

@coryan coryan marked this pull request as ready for review June 22, 2021 04:27
@coryan coryan requested a review from a team June 22, 2021 04:27
@coryan coryan merged commit 54f4b5c into googleapis:main Jun 22, 2021
@coryan coryan deleted the feat-common-long-running-cancel-for-realsies branch June 22, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan @google-cloud-cpp-bot @devbww @googlebot