feat(generator): use async for long-running operations#6830
Merged
coryan merged 2 commits intogoogleapis:mainfrom Jun 22, 2021
Merged
feat(generator): use async for long-running operations#6830coryan merged 2 commits intogoogleapis:mainfrom
coryan merged 2 commits intogoogleapis:mainfrom
Conversation
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6830 +/- ##
==========================================
- Coverage 95.04% 95.04% -0.01%
==========================================
Files 1264 1264
Lines 113316 113312 -4
==========================================
- Hits 107697 107693 -4
Misses 5619 5619
Continue to review full report at Codecov.
|
coryan
force-pushed
the
feat-generator-use-async-for-long-running
branch
from
d2dceef to
b95a7cb
Compare
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
For long-running operations we need to generate three different RPCs: one to start the operation (e.g. `CreateDatabase()`), one to poll the operation (`GetOperation()`), and one to cancel the operation (`CancelOperation()`). With this change all the three RPCs are generated as asynchronous RPCs. The `*Connection` class can use these asynchronous RPCs in the background, using the background threads. This (1) avoids creating a detached thread to poll the operation, (2) uses code that is more easily unit tested separate from the generated libraries.
coryan
force-pushed
the
feat-generator-use-async-for-long-running
branch
from
b95a7cb to
145830a
Compare
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devjgm
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For long-running operations we need to generate three different RPCs:
one to start the operation (e.g.
CreateDatabase()), one to poll theoperation (
GetOperation()), and one to cancel the operation(
CancelOperation()). With this change all the three RPCs aregenerated as asynchronous RPCs.
The
*Connectionclass can use these asynchronous RPCs in thebackground, using the background threads. This (1) avoids creating a
detached thread to poll the operation, (2) uses code that is more easily
unit tested separate from the generated libraries.
Fixes #6821
This change is