refactor(common): re-use value extractors in synchronous polling loop#6823
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jun 21, 2021
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6823 +/- ##
==========================================
- Coverage 95.03% 95.02% -0.01%
==========================================
Files 1264 1264
Lines 113172 113150 -22
==========================================
- Hits 107553 107526 -27
- Misses 5619 5624 +5
Continue to review full report at Codecov.
|
devbww
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a cleanup after some of the work for #6821
This change is