Skip to content

feat(common): support response in long-running operations#6822

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-common-extract-long-running-response
Jun 21, 2021
Merged

feat(common): support response in long-running operations#6822
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-common-extract-long-running-response

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jun 21, 2021 •
edited
Loading

Some long-running operations return their value in the response field,
while others use the metadata field, with this change both are
supported.

Part of the work for #6821

This change is Reviewable

@coryan
feat(common): support response in long-running operations
f8e47b3 
Some long-running operations return their value in the `response` field,
while others use the `metadata` field, with this change both are
supported.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 21, 2021

Google Cloud Build Logs
For commit: f8e47b36b2f972d9121ca47a43be4fc4ab7508d2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #6822 (f8e47b3) into main (0dfde77) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6822   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files        1264     1264           
  Lines      113076   113172   +96     
=======================================
+ Hits       107458   107554   +96     
  Misses       5618     5618
Impacted Files Coverage Δ
...ogle/cloud/internal/async_long_running_operation.h 93.75% <100.00%> (ø)
...loud/internal/async_long_running_operation_test.cc 96.42% <100.00%> (+2.67%) ⬆️
...ogle/cloud/internal/extract_long_running_result.cc 100.00% <100.00%> (ø)
...oogle/cloud/internal/extract_long_running_result.h 100.00% <100.00%> (ø)
...cloud/internal/extract_long_running_result_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_rpc_details.h 94.11% <0.00%> (-5.89%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.60% <0.00%> (+0.59%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 97.90% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfde77...f8e47b3. Read the comment docs.

@coryan coryan marked this pull request as ready for review June 21, 2021 17:39
@coryan coryan requested a review from a team June 21, 2021 17:39
@coryan coryan merged commit 2038107 into googleapis:main Jun 21, 2021
@coryan coryan deleted the feat-common-extract-long-running-response branch June 21, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan @google-cloud-cpp-bot @devbww @googlebot