Skip to content

refactor(common): move longrunning to value functions#6820

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:refactor-common-split-extract-long-running-result
Jun 21, 2021
Merged

refactor(common): move longrunning to value functions#6820
coryan merged 1 commit intogoogleapis:mainfrom
coryan:refactor-common-split-extract-long-running-result

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jun 21, 2021 •
edited
Loading

I am planning to re-use these functions for the non-async case, so it
seems reasonable to split them to a separate file.

Part of the work for #6821

This change is Reviewable

@coryan
refactor(common): move longrunning to value functions
eed61ec 
I am planning to re-use these functions for the non-async case, so it
seems reasonable to split them to a separate file.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #6820 (eed61ec) into main (59d7cf6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6820   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files        1262     1264    +2     
  Lines      113045   113045           
=======================================
+ Hits       107427   107431    +4     
+ Misses       5618     5614    -4
Impacted Files Coverage Δ
...ogle/cloud/internal/async_long_running_operation.h 93.75% <ø> (-1.91%) ⬇️
...loud/internal/async_long_running_operation_test.cc 93.75% <ø> (-2.73%) ⬇️
...ogle/cloud/internal/extract_long_running_result.cc 100.00% <ø> (ø)
...oogle/cloud/internal/extract_long_running_result.h 100.00% <100.00%> (ø)
...cloud/internal/extract_long_running_result_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/async_rpc_details.h 94.11% <0.00%> (-5.89%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.76% <0.00%> (-0.47%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.75% <0.00%> (+0.07%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d7cf6...eed61ec. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 21, 2021

Google Cloud Build Logs
For commit: eed61ec80afa2dd820a88e3726f57a202ede3501

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review June 21, 2021 15:28
@coryan coryan requested a review from a team June 21, 2021 15:28
@coryan coryan merged commit 0dfde77 into googleapis:main Jun 21, 2021
@coryan coryan deleted the refactor-common-split-extract-long-running-result branch June 21, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan @google-cloud-cpp-bot @devbww @googlebot