Skip to content

refactor(generator): de-duplicate mock stubs#6814

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:refactor-generator-deduplicate-mock-stubs
Jun 21, 2021
Merged

refactor(generator): de-duplicate mock stubs#6814
coryan merged 1 commit intogoogleapis:mainfrom
coryan:refactor-generator-deduplicate-mock-stubs

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jun 20, 2021

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 30149e4d912a6f4daae02a5d1580a0d81ab41982

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2021

Codecov Report

Merging #6814 (30149e4) into main (44d66a4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6814      +/-   ##
==========================================
- Coverage   95.02%   95.02%   -0.01%     
==========================================
  Files        1262     1262              
  Lines      113094   113041      -53     
==========================================
- Hits       107472   107420      -52     
+ Misses       5622     5621       -1     
Impacted Files Coverage Δ
...olden/tests/golden_kitchen_sink_connection_test.cc 98.09% <ø> (-0.07%) ⬇️
...sts/golden_kitchen_sink_metadata_decorator_test.cc 98.87% <100.00%> (-0.08%) ⬇️
...golden/tests/golden_thing_admin_connection_test.cc 99.64% <100.00%> (-0.01%) ⬇️
...ests/golden_thing_admin_metadata_decorator_test.cc 100.00% <100.00%> (ø)
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.60% <0.00%> (+0.59%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d66a4...30149e4. Read the comment docs.

@coryan coryan marked this pull request as ready for review June 20, 2021 15:04
@coryan coryan requested a review from a team June 20, 2021 15:04
@coryan coryan merged commit 59d7cf6 into googleapis:main Jun 21, 2021
@coryan coryan deleted the refactor-generator-deduplicate-mock-stubs branch June 21, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants