Skip to content

ci: use emulator for Spanner and Bazel#6812

Merged
coryan merged 4 commits intogoogleapis:mainfrom
coryan:ci-use-emulator-for-spanner-and-bazel
Jun 19, 2021
Merged

ci: use emulator for Spanner and Bazel#6812
coryan merged 4 commits intogoogleapis:mainfrom
coryan:ci-use-emulator-for-spanner-and-bazel

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jun 19, 2021 •
edited by devbww
Loading

Avoids some flakes by using the emulator. We still have
some builds hitting production, mostly macOS and Windows.

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 19, 2021

Google Cloud Build Logs
For commit: 9853f066cce4147c07d6ea1f8ae7f2eb6bdbf3c7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 19, 2021

Google Cloud Build Logs
For commit: 30fcddb91eb9120d31fdc1e20a804260e47424be

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review June 19, 2021 00:44
@coryan coryan requested a review from a team June 19, 2021 00:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2021 •
edited
Loading

Codecov Report

Merging #6812 (5a3f046) into main (e9b7bff) will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6812      +/-   ##
==========================================
- Coverage   95.51%   95.02%   -0.49%     
==========================================
  Files        1262     1262              
  Lines      113094   113094              
==========================================
- Hits       108026   107473     -553     
- Misses       5068     5621     +553
Impacted Files Coverage Δ
google/cloud/spanner/testing/random_backup_name.cc 0.00% <0.00%> (-100.00%) ⬇️
...tegration_tests/database_admin_integration_test.cc 55.87% <0.00%> (-39.28%) ⬇️
...ogle/cloud/spanner/internal/instance_admin_stub.cc 65.97% <0.00%> (-23.72%) ⬇️
...ogle/cloud/spanner/internal/database_admin_stub.cc 37.90% <0.00%> (-19.61%) ⬇️
google/cloud/spanner/samples/samples.cc 66.99% <0.00%> (-15.80%) ⬇️
...ogle/cloud/spanner/testing/pick_instance_config.cc 85.00% <0.00%> (-15.00%) ⬇️
...tegration_tests/instance_admin_integration_test.cc 79.43% <0.00%> (-14.90%) ⬇️
google/cloud/kms_key_name.h 85.71% <0.00%> (-14.29%) ⬇️
...r/integration_tests/data_types_integration_test.cc 86.86% <0.00%> (-12.13%) ⬇️
...e/cloud/spanner/internal/instance_admin_logging.cc 90.90% <0.00%> (-9.10%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b7bff...5a3f046. Read the comment docs.

devbww
devbww approved these changes Jun 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread google/cloud/spanner/ci/run_integration_tests_emulator_bazel.sh
--test_env="GOOGLE_CLOUD_CPP_AUTO_RUN_EXAMPLES=yes" \
--test_env="GOOGLE_CLOUD_CPP_EXPERIMENTAL_LOG_CONFIG=lastN,100,WARNING" \
--test_env="GOOGLE_CLOUD_CPP_ENABLE_TRACING=rpc,rpc-streams" \
--test_env="GOOGLE_CLOUD_CPP_TRACING_OPTIONS=truncate_string_field_longer_than=512" \
Copy link
Copy Markdown
Contributor

@devbww devbww Jun 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmake version sets GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS="instance,backup", which I imagine is OK because the emulator doesn't actually support the slow operations. Either way, we should probably make in the bazel/cmake invocations match as much as possible.

Copy link
Copy Markdown
Contributor Author

@coryan coryan Jun 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Jun 19, 2021

PTAL, I made some additional changes to ensure the Bazel caches the test results.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jun 19, 2021

Google Cloud Build Logs
For commit: 5a3f0464a6af61945f9d599d8a8c481cb286001b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 44d66a4 into googleapis:main Jun 19, 2021
@coryan coryan deleted the ci-use-emulator-for-spanner-and-bazel branch June 19, 2021 15:56
@coryan coryan mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@devjgm devjgm devjgm approved these changes

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coryan @google-cloud-cpp-bot @devjgm @devbww @googlebot