ci: increase the GCB timeout#6795
Merged
devbww merged 1 commit intogoogleapis:mainfrom Jun 17, 2021
Merged
Conversation
We've been seeing some timeouts from the `integration-daily` build since disabling CI-build test-result caching. This should not be too surprising given that the slow Spanner backup/instance tests and samples already take a good part of the allotted 1h, and are subject to scheduling delays in the backend. So, increase the timeout to 2h. I couldn't, for the life of me, figure out how to parameterize the timeout with a `gcloud builds submit --substitutions=`, and chose not to move the value out to a `--timeout=` flag, so this simply raises the limit for all builds. Alternative ideas are welcomed.
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6795 +/- ##
==========================================
- Coverage 95.51% 95.51% -0.01%
==========================================
Files 1257 1257
Lines 112769 112769
==========================================
- Hits 107708 107706 -2
- Misses 5061 5063 +2
Continue to review full report at Codecov.
|
devjgm
approved these changes
Jun 17, 2021
Contributor
devjgm
left a comment
devjgm
left a comment
There was a problem hiding this comment.
I think this way of doing it is fine and simple. LGTM. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing some timeouts from the
integration-dailybuild since disabling CI-build test-result caching. This
should not be too surprising given that the slow Spanner
backup/instance tests and samples already take a good part
of the allotted 1h, and are subject to scheduling delays in
the backend. So, increase the timeout to 2h.
I couldn't, for the life of me, figure out how to parameterize
the timeout with a
gcloud builds submit --substitutions=,and chose not to move the value out to a
--timeout=flag,so this simply raises the limit for all builds. Alternative
ideas are welcomed.
This change is