test(storage): deflake integration tests#6792
Merged
coryan merged 3 commits intogoogleapis:mainfrom Jun 16, 2021
Merged
Conversation
Use a different instance of the emulator to run the **emulator** tests vs. the tests that **use** the emulator. The emulator tests intentionally crash some of the emulator workers, which then causes problems for the regular tests. Note that the emulator tests themselves are still flaky, but they are very fast so using `--flake-test_attempts` mostly workarounds the problem.
product-auto-label
Bot
added
the
api: storage
google-cla
Bot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6792 +/- ##
=======================================
Coverage 95.50% 95.51%
=======================================
Files 1257 1257
Lines 112769 112769
=======================================
+ Hits 107705 107706 +1
+ Misses 5064 5063 -1
Continue to review full report at Codecov.
|
devbww
reviewed
Jun 16, 2021
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a different instance of the emulator to run the emulator tests
vs. the tests that use the emulator. The emulator tests
intentionally crash some of the emulator workers, which then causes
problems for the regular tests. Note that the emulator tests themselves
are still flaky, but they are very fast so using
--flake-test_attemptsmostly avoids the problem.
Part of the work for #6641
This change is