test(storage): resumable uploads abort on errors#6790
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jun 16, 2021
Merged
Conversation
This new test verifies that resumable uploads abort (do not finalize) if one of the intermediate `UploadChunk()` requests has a permanent error or otherwise exhaust the retry policy. I wrote this test expecting that the library had a bug and needed fixing, but turns out I do not give myself enough credit.
product-auto-label
Bot
added
the
api: storage
googlebot
added
the
cla: yes
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6790 +/- ##
==========================================
- Coverage 95.81% 95.51% -0.31%
==========================================
Files 1212 1257 +45
Lines 107414 112767 +5353
==========================================
+ Hits 102920 107704 +4784
- Misses 4494 5063 +569
Continue to review full report at Codecov.
|
devbww
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new test verifies that resumable uploads abort (do not finalize) if
one of the intermediate
UploadChunk()requests has a permanent erroror otherwise exhaust the retry policy. I wrote this test expecting that
the library had a bug and needed fixing, but turns out I do not give
myself enough credit.
Fixes #6779
This change is