feat(storage): add Retry Test API to emulator by frankyn · Pull Request #6611 · googleapis/google-cloud-cpp

frankyn · 2021-05-19T03:12:38Z

cc: @tritone

Adding Retry Test API support to the emulator

This change is

google-cloud-cpp-bot · 2021-05-19T03:14:52Z

Google Cloud Build Logs
For commit: d7582b6c776931ba8099844673163abff39e74a6

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

codecov · 2021-05-19T03:25:52Z

Codecov Report

Merging #6611 (e19adff) into main (04e1b3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6611   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files        1211     1211           
  Lines      107401   107401           
=======================================
  Hits       102914   102914           
  Misses       4487     4487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e1b3a...e19adff. Read the comment docs.

coryan

See below, I like the general direction btw.

google-cloud-cpp-bot · 2021-05-21T18:22:35Z

Google Cloud Build Logs
For commit: 8caeba81dbd14c4941ac5f44c7a95034165f7833

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2021-05-21T23:19:41Z

Google Cloud Build Logs
For commit: 782d9f5ee0645cb42714c2baa6d8862bcf6a6b78

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2021-05-22T00:31:33Z

Google Cloud Build Logs
For commit: b996679af727df8380ef25478f7a839446249473

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2021-05-22T00:36:51Z

Google Cloud Build Logs
For commit: e729f58c793acfeda31d52ffd4a662c316564ce6

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

coryan

I think the motivation could be made crisper. But otherwise this LGTM.

tritone

Looking good!

google-cloud-cpp-bot · 2021-05-26T20:47:19Z

Google Cloud Build Logs
For commit: 72f22b7c6987d6f7cd277fa9d78449869bed610d

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

coryan

LGTM

coryan · 2021-05-26T20:54:06Z

+
+Sending a constant header with all RPCs can be implemented across all client libraries,
+and to some degree decouples the test setup from the test execution.
+


nit: blank line ?

... i love extra empty lines.

google-cloud-cpp-bot · 2021-05-26T21:18:42Z

Google Cloud Build Logs
For commit: e19adff8772802846b8bbc3e2fe9474af63cacd9

Public Access Build Logs
Cloud Build Console (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

feat(storage): add Retry Test API to emulator

d7582b6

frankyn requested a review from a team May 19, 2021 03:12

product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 19, 2021

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021

coryan requested changes May 19, 2021

View reviewed changes

tritone reviewed May 19, 2021

View reviewed changes

Comment thread google/cloud/storage/emulator/README.md

Comment thread google/cloud/storage/emulator/README.md Outdated

Comment thread google/cloud/storage/emulator/database.py

Comment thread google/cloud/storage/emulator/emulator.py

Comment thread google/cloud/storage/emulator/emulator.py

update README.md with motivation

8caeba8

Frank Natividad added 2 commits May 21, 2021 16:14

validate retry test input

9af654d

blacken code

782d9f5

refactor handle_retry_test_instruction

b996679

refactor handle_retry_test_instruction x2

e729f58

frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021

frankyn requested review from cojenco, coryan and tritone May 24, 2021 17:06

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2021

coryan approved these changes May 25, 2021

View reviewed changes

Comment thread google/cloud/storage/emulator/README.md

Comment thread google/cloud/storage/emulator/README.md Outdated

Comment thread google/cloud/storage/emulator/utils/common.py

Comment thread google/cloud/storage/emulator/README.md Outdated

tritone approved these changes May 26, 2021

View reviewed changes

Comment thread google/cloud/storage/emulator/README.md

Comment thread google/cloud/storage/emulator/database.py

coryan requested changes May 26, 2021

View reviewed changes

Comment thread google/cloud/storage/emulator/README.md

address motiviation feedback

72f22b7

coryan approved these changes May 26, 2021

View reviewed changes

remove empty line

e19adff

coryan merged commit 1987b80 into googleapis:main May 26, 2021

devjgm mentioned this pull request May 27, 2021

[Flake] //google/cloud/storage/emulator:test_utils fails #6641

Closed

frankyn mentioned this pull request Aug 19, 2021

Storage: Introduce failures into uploads with return-XXX-after-YYYk when using Retry Test API googleapis/storage-testbench#54

Closed

frankyn mentioned this pull request Oct 26, 2021

Storage(emulator): Add unit tests to validate all GCS APIs are supported with Retry Test API googleapis/storage-testbench#157

Open


		Sending a constant header with all RPCs can be implemented across all client libraries,
		and to some degree decouples the test setup from the test execution.

Conversation

frankyn commented May 19, 2021 • edited by coryan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cloud-cpp-bot commented May 19, 2021

Uh oh!

codecov Bot commented May 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cloud-cpp-bot commented May 21, 2021

Uh oh!

google-cloud-cpp-bot commented May 21, 2021

Uh oh!

google-cloud-cpp-bot commented May 22, 2021

Uh oh!

google-cloud-cpp-bot commented May 22, 2021

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tritone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cloud-cpp-bot commented May 26, 2021

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

coryan May 26, 2021

Choose a reason for hiding this comment

Uh oh!

frankyn May 26, 2021

Choose a reason for hiding this comment

Uh oh!

google-cloud-cpp-bot commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

frankyn commented May 19, 2021 •

edited by coryan

Loading

codecov Bot commented May 19, 2021 •

edited

Loading