ci: reintroduce logging of important build commands#6609
ci: reintroduce logging of important build commands#6609devbww merged 3 commits intogoogleapis:mainfrom
Conversation
Rebrand `io::log_cmdline` as `io::log_and_run`, which, as the name suggests, now also executes the command so as to eliminate duplication at the call site. This version also adds quoting. Introduce `io::log_and_run` into the `ci/cloudbuild/build.sh` script. Additions to any of the `ci/cloudbuild/builds/*.sh` scripts can be made as the need arises.
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6609 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 1211 1211
Lines 107401 107401
=======================================
Hits 102914 102914
Misses 4487 4487 Continue to review full report at Codecov.
|
devjgm
left a comment
devjgm
left a comment
There was a problem hiding this comment.
LGTM as-is. I'd also be OK w/ a shorter name like io::run since the io:: part gives some hint that something will be logged also. But I'm happy w/ whatever you decide.
Done. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
4 participants
Rebrand
io::log_cmdlineasio::log_and_run, which, as thename suggests, now also executes the command so as to eliminate
duplication at the call site. This version also adds quoting.
Introduce
io::log_and_runinto theci/cloudbuild/build.shscript. Additions to any of the
ci/cloudbuild/builds/*.shscripts can be made as the need arises.
This change is