chore: Configure tsan and msan builds. #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This change configures (but does not enable) the tsan (ThreadSanitizer) and msan (MemorySanitizer) builds. The are a couple of changes in the code: - tsan found a real race condition in `google::cloud::promise<T>`, also created a couple of unit tests to repro the bug with minimal overhead. - msan yields a false positive for one of the tests related to signal handlers. I chose to simply disable the test in this case. A separate change inside Google will enable these builds.
coryan
force-pushed
the
configure-tsan-and-msan-builds
branch
from
21c6f71 to
cbf37c8
Compare
devjgm
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change configures (but does not enable) the tsan (ThreadSanitizer)
and msan (MemorySanitizer) builds. The are a couple of changes in the
code:
google::cloud::promise<T>, alsocreated a couple of unit tests to repro the bug with minimal overhead.
handlers. I chose to simply disable the test in this case.
A separate change inside Google will enable these builds.
Fixes #62
This change is