Make versions consistent #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
requested review from
AVaksman,
DanielMahu,
ajaaym,
deepankarsharma,
garye,
hemant-qlogic,
manish-qlogic,
mbrukman,
paprat,
rameshdharan,
richjames0 and
sduskis
googlebot
added
the
cla: yes
manish-qlogic
approved these changes
Mar 2, 2018
hemant-qlogic
approved these changes
Mar 2, 2018
The documentation, Makefiles, and the code had different version numbers, fixed it by using the Makefile version numbers everywhere. This fixes googleapis#238. Also use CMake to call doxygen, which allows us to refactor the common parts of the Doxyfile, this fixes googleapis#71.
This is not a feature needed by all developers or users, so disable it if the necessary tools are not found instead of failing the build.
coryan
force-pushed
the
make-versions-consistent
branch
from
17734b1 to
61a45a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the version numbers reported by CMake, by the header files (which gets included in each RPC metadata), and by the Doxygen documentation consistent. The numbers from CMake are used by all three locations. This fixes #238. In addition, because CMake drives the generation of the Doxygen file, the common parts can be refactored, so this fixes #71 too.