Refactor bigtable::AdminClient and bigtable::DataClient. #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
cla: yes
Contributor
Author
|
Ping. |
Contributor
Author
|
@garye can you take a look? @carterpage got busy (as he should) and can no longer do reviews. |
garye
approved these changes
Jan 18, 2018
| channel_.reset(); | ||
| } | ||
|
|
||
| StubPtr Stub() { |
There was a problem hiding this comment.
Worth talking about the thread safey or lack thereof in these interfaces? Not sure if we do that throughout...
Contributor
Author
There was a problem hiding this comment.
Absolutely worth it. This is the only interface so far that may be used in multiple threads. The intention is to make them thread-safe after refactoring.
bigtable/admin/admin_client.cc
Outdated
| ::google::bigtable::admin::v2::BigtableTableAdmin::NewStub(channel); | ||
| channel_ = std::move(channel); | ||
| } | ||
| SimpleAdminClient(std::string project, bigtable::ClientOptions options) |
There was a problem hiding this comment.
Why Simple AdminClient and Default DataClient? Are they both the default?
Contributor
Author
There was a problem hiding this comment.
Fixed (assuming it compiles and stuff).
There was a certain amount of duplication in these classes. This change fixes that. As a side-effect, it fixes googleapis#107 too. This change does not attempt to *use* both classes the same way, though we should, I do not want to introduce more changes in a PR that basically refactors things.
Use CreateDefault*Client instead of some with Default and some without. Also use Default*Client instead of Simple*Client for one and Default*Client for the other. Thanks to @garye for noticing.
coryan
force-pushed
the
refactor-clients
branch
from
bd069e4 to
234dfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a certain amount of duplication in these classes. This
change fixes that. As a side-effect, it fixes #107 too.
This change does not attempt to use both classes the same way,
though we should: I do not want to introduce more changes in a
PR that basically refactors things.