feat(credentials): add support for creating ComputeEngine credentials explicitly#15789
Merged
scotthart merged 1 commit intogoogleapis:mainfrom Nov 23, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15789 +/- ##
==========================================
- Coverage 92.94% 92.94% -0.01%
==========================================
Files 2454 2457 +3
Lines 226878 226942 +64
==========================================
+ Hits 210879 210926 +47
- Misses 15999 16016 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
diegomarquezp
left a comment
diegomarquezp
left a comment
There was a problem hiding this comment.
LGTM code-wise, but I'd like to understand how does credential parsing work in cpp. In java, we parse a stream or JSON containing expected fields per credential type and validate their existence, but I'm not sure if the same mechanism exists in cpp auth.
diegomarquezp
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15673