Skip to content

feat(credentials): add support for creating ComputeEngine credentials explicitly #15789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scotthart merged 1 commit into from
Nov 23, 2025
Merged

feat(credentials): add support for creating ComputeEngine credentials explicitly #15789

scotthart merged 1 commit into from
Nov 23, 2025
+246 −0

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Nov 21, 2025 •
edited
Loading

fixes #15673

@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.87500% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (45fe5af) to head (83cd9ea).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...cloud/storage/internal/unified_rest_credentials.cc 0.00% 6 Missing ⚠️
...oud/internal/grpc_compute_engine_authentication.cc 70.58% 5 Missing ⚠️
google/cloud/testing_util/credentials.h 0.00% 4 Missing ⚠️
google/cloud/internal/unified_grpc_credentials.cc 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15789      +/-   ##
==========================================
- Coverage   92.94%   92.94%   -0.01%     
==========================================
  Files        2454     2457       +3     
  Lines      226878   226942      +64     
==========================================
+ Hits       210879   210926      +47     
- Misses      15999    16016      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart marked this pull request as ready for review November 21, 2025 16:43
@scotthart scotthart requested review from a team as code owners November 21, 2025 16:43
diegomarquezp
diegomarquezp reviewed Nov 21, 2025
View reviewed changes
Copy link
Collaborator

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, but I'd like to understand how does credential parsing work in cpp. In java, we parse a stream or JSON containing expected fields per credential type and validate their existence, but I'm not sure if the same mechanism exists in cpp auth.

@scotthart scotthart merged commit 4ac3fe1 into googleapis:main Nov 23, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add MakeComputeEngineCredentials to unified credentials.

2 participants

@scotthart @diegomarquezp