fix(storage): Add start appendable condition for bypassing full object checksum #15786
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15786 +/- ##
=======================================
Coverage 92.94% 92.95%
=======================================
Files 2454 2454
Lines 226878 226922 +44
=======================================
+ Hits 210879 210929 +50
+ Misses 15999 15993 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a checksum mismatch error occurring during appendable uploads. The fix involves adding a condition to correctly identify appendable uploads when finalizing a write, ensuring that the full object checksum is bypassed as it's not available for these types of objects. The change is logical and directly addresses the described problem. I have one minor suggestion to improve code readability.
bajajneha27
left a comment
bajajneha27
left a comment
There was a problem hiding this comment.
LGTM! Can we please add a testcase too?
3 participants
We are getting checksum mismatch error for few of the appendable uploads, this condition was missing. We need to add this condition since full object checksum is not available for fastbyte objects.
