fix(storage): enable fast resume for rapid object write streams by including write handle #15762
Conversation
product-auto-label
bot
added
the
api: storage
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
Summary of ChangesHello @shubham-up-47, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the C++ SDK's handling of Rapid object write stream reconnections. By ensuring that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly enables fast resume for rapid object write streams by including the write_handle in the resume request. The implementation is straightforward and the new tests properly cover both the positive and negative cases. I have a couple of suggestions to simplify the test code by removing redundant lines, improving conciseness and maintainability.
google/cloud/storage/internal/async/writer_connection_resumed_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/storage/internal/async/writer_connection_resumed_test.cc
Outdated
Show resolved
Hide resolved
shubham-up-47
temporarily deployed
to
external
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15762 +/- ##
==========================================
+ Coverage 92.95% 92.96% +0.01%
==========================================
Files 2448 2448
Lines 226319 226324 +5
==========================================
+ Hits 210372 210406 +34
+ Misses 15947 15918 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-up-47
deleted the
reconnect_async_write_stream_with_write_handle
branch
3 participants
This PR ensures that when the C++ SDK reconnects write streams for Rapid objects, it includes the write_handle in the resume request. This enables fast resume instead of slow takeover, significantly reducing reconnect latency and avoiding offset mismatch errors.