Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Dec 28, 2017

This fixes #36. The files are renamed too, and new README.md
files provide warning to any user that chooses to use the
contents of the internal/ directory.

This fixes googleapis#36.  The files are renamed too, and new README.md
files provide warning to any user that chooses to use the
contents of the internal/ directory.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2017
Copy link
Contributor

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrukman mbrukman merged commit 745428e into googleapis:master Dec 28, 2017
@coryan coryan deleted the rename-detail-to-internal branch December 28, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor implementation detail classes to internal/ subdirectory.

3 participants