feat(storage): Add samples related to AppendableObject and OpenObject #15563
Conversation
product-auto-label
bot
added
api: storage
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15563 +/- ##
==========================================
+ Coverage 93.05% 93.07% +0.01%
==========================================
Files 2414 2414
Lines 221063 221114 +51
==========================================
+ Hits 205720 205795 +75
+ Misses 15343 15319 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-up-47
force-pushed
the
fastbyte_samples
branch
from
a61762d to
f0acefb
Compare
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
| futures.push_back(count_newlines(std::move(reader), std::move(token))); | ||
| } | ||
|
|
||
| // Wait for all futures and print results |
There was a problem hiding this comment.
nit: I think we should not be waiting for all the futures to be ready, we should just start reading the futures which are ready.
There was a problem hiding this comment.
Done, please re-check.
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
shubham-up-47
temporarily deployed
to
external
GitHub Actions
Inactive
bajajneha27
left a comment
bajajneha27
left a comment
There was a problem hiding this comment.
Just get alignment on region tags, rest everything looks good to me.
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @bajajneha27)
4 participants
This change is