fix(storage): Fix Resume() to use append_object_spec instead of write_object_spec for resumed appendable uploads #15558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Error
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15558 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 2411 2411
Lines 220299 220346 +47
=======================================
+ Hits 204978 205022 +44
- Misses 15321 15324 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
v-pratap
reviewed
Sep 22, 2025
google/cloud/storage/internal/async/writer_connection_resumed.cc
Outdated
Show resolved
Hide resolved
shubham-up-47
temporarily deployed
to
external
GitHub Actions
Inactive
bajajneha27
approved these changes
Sep 22, 2025
shubham-up-47
changed the title
scotthart
approved these changes
Sep 23, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @v-pratap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the logic in AsyncWriterConnectionResumedState::Resume() where it incorrectly assumed initial_request_ would always contain an write_object_spec. This assumption fails when resuming an upload that was initiated with ResumeAppendableObjectUpload, which uses append_object_spec, which leads to passing the bucket and object names empty.
The fix introduces a check to determine whether initial_request_ contains a write_object_spec or an append_object_spec, and then correctly extracts the bucket and object names from the available spec. This approach aligns with the pattern already used in WriteResultFactory for handling these two types of specifications.
This change is