feat(storage): Remove unnecessary code which was causing race condition #15551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15551 +/- ##
==========================================
- Coverage 93.03% 93.03% -0.01%
==========================================
Files 2408 2408
Lines 219826 219825 -1
==========================================
- Hits 204526 204525 -1
Misses 15300 15300 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rajeevpodar
approved these changes
Sep 17, 2025
bajajneha27
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting writing_ = false in SetFlushed() is premature because the Flush-Query operation is not complete until OnQuery() finishes. This prematurely signals that no write is in progress, opening a window where StartWriting() can be called again before OnQuery() restarts or terminates the WriteLoop(), leading to concurrent write/flush operations.
To fix this, I am removing writing_ = false; from SetFlushed(). The writing_ flag will now only be updated by WriteLoop() based on whether there is more data to send, or when an error occurs. This ensures writing_ correctly reflects whether an operation is in flight.
This change is