feat(storage): Update the appendable object function to store the Object metadata #15422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
v-pratap
force-pushed
the
persisted-state
branch
from
465cd65 to
38e680e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15422 +/- ##
==========================================
- Coverage 93.04% 93.03% -0.01%
==========================================
Files 2408 2408
Lines 219826 219826
==========================================
- Hits 204529 204523 -6
- Misses 15297 15303 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bajajneha27
approved these changes
Sep 16, 2025
v-pratap
force-pushed
the
persisted-state
branch
from
9735c9f to
3c7459e
Compare
v-pratap
force-pushed
the
persisted-state
branch
from
3c7459e to
2c8a48f
Compare
scotthart
approved these changes
Sep 16, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 2 of 5 files at r1, 2 of 2 files at r3, 2 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @v-pratap)
google/cloud/storage/internal/async/writer_connection_impl.cc line 67 at r5 (raw file):
std::move(options), std::move(request), std::move(impl), std::move(hash_function), PersistedStateType(metadata), /*offset=*/metadata.size(), std::move(first_request)) {}
There's no benefit (and possibly even a pessimization) to std::move on a bool, or any other fundamental data type.
Member
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the the first connection in appendable object upload, we are getting object metadata in response, but we were only storing persisted size out of it, so updating the code so that we will store the object metadata.
This change is