Fix document upload after #138. #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documents are generated inside a docker image, in a previous change (googleapis#138), the path for the generated docs was changed. This script should have been changed at the same time. While testing I found out that there was another tiny problem, the documents were never uploaded because the change detection was broken. Fix that too <blush>.
coryan
added
type: bug
googlebot
added
the
cla: yes
Contributor
Author
|
Ping, you seem to have missed this one. |
mbrukman
suggested changes
Dec 30, 2017
.gitignore
Outdated
| # The Doxygen-generated documentation goes here: | ||
| bigtable/doc/html/ | ||
| doc/html/ | ||
| gh-pages/ |
Contributor
There was a problem hiding this comment.
Why is this a directory? This should be a branch name, so it shouldn't be in a .gitignore, unless I'm missing something.
Contributor
Author
There was a problem hiding this comment.
The script creates a temporary clone of the gh-pages branch in the gh-pages directory, and copies the (potentially new) documentation into it:
Happy to name it something else if you think that is confusing.
Contributor
There was a problem hiding this comment.
Ah, sorry, missed that entirely. Yes, please, let's call it something different like docs-build so that others are not confused reading this.
Thanks to @mbrukman, this is less confusing indeed.
Contributor
Author
|
PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documents are generated inside a docker image, in a previous
change (#138), the path for the generated docs was changed. This
script should have been changed at the same time.
While testing I found out that there was another tiny problem, the
documents were never uploaded because the change detection was
broken. Fix that too .