feat(storage): Add generation in append_object_spec in resume operation #15395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15395 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 2403 2403
Lines 219557 219610 +53
=======================================
+ Hits 204279 204342 +63
+ Misses 15278 15268 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bajajneha27
reviewed
Aug 25, 2025
v-pratap
force-pushed
the
add-generation-in-append-object-spec
branch
from
dc888ec to
70705e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncWriter in the C++ SDK does not set append_object_spec.generation when it reconnects a write stream, but that is required by the protocol. We have added a first-response field so that in future we can leverage that for other fields while resuming.
Without this change we were getting this error:
![Uploading Screenshot 2025-08-17 at 11.30.52 AM.png…]()
With this change we are not getting the error:
This change is