perf: Change StreamingReadRpc::Read interface to take ResponseType #15319
Conversation
This allows the caller to allocate the ResponseType on an arena and better matches the underlying GRPC interface
andrewro-google
changed the title
|
/gcbrun |
|
Fixed the generator and now |
|
/gcbrun |
|
Fixed clang errors |
|
Friendly ping |
|
/gcbrun |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15319 +/- ##
========================================
Coverage 93.03% 93.03%
========================================
Files 2403 2403
Lines 219441 219553 +112
========================================
+ Hits 204148 204272 +124
+ Misses 15293 15281 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewro-google
temporarily deployed
to
external
GitHub Actions
Inactive
|
/gcbrun |
|
Friendly ping. Seem like the only tests not running need another level of approval |
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 23 of 29 files at r1, 8 of 8 files at r2, 4 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewro-google)
andrewro-google
temporarily deployed
to
external
GitHub Actions
Inactive
|
@BenWhitehead could you take a look as a member of gcs-sdk-team? Thanks! |
|
/gcbrun |
| return response; | ||
| .WillOnce([](storage_proto::ReadObjectResponse* r) { | ||
| SetContent(*r, "0123456789"); | ||
| return absl::nullopt; |
There was a problem hiding this comment.
Why are we returning nullopt instead of the response?
There was a problem hiding this comment.
Read's API now returns nullopt when there are more results coming or the final RPC Status. In this test we have a few results before sending a final status::OK
@andrewro-google I reviewed on behalf of gcs-sdk-team. |
|
/gcbrun |
4 participants
This allows the caller to allocate the ResponseType on an arena and better matches the underlying GRPC interface
TESTED=bazel test //google/... --test_tag_filters=-integration-test,-benchmark,-sample
This change is