feat(spanner): add support for lock_hint enum #15249
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15249 +/- ##
========================================
Coverage 92.92% 92.93%
========================================
Files 2394 2394
Lines 215461 215564 +103
========================================
+ Hits 200227 200329 +102
- Misses 15234 15235 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 9 of 11 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion
google/cloud/spanner/client.cc line 57 at r2 (raw file):
auto directed_read_option = ExtractOpt<DirectedReadOption>(opts); internal::OptionsSpan span(std::move(opts)); auto lock_hint = ExtractOpt<LockHintOption>(opts);
Here and in the other places we call ExtractOpt for the LockHintOption, we want to do this before we create the OptionSpan.
Ah good catch, thank you! Done, also added additional testing in client_test. |
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mpeddada1)
2 participants
This PR does the following:
The setup is very similar to what we have for feat(spanner): add support for order_by enum #15240
This change is