feat(spanner): add support for order_by enum #15240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15240 +/- ##
========================================
Coverage 92.93% 92.93%
========================================
Files 2394 2394
Lines 215384 215652 +268
========================================
+ Hits 200163 200417 +254
- Misses 15221 15235 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mpeddada1)
| OrderBy order_by; | ||
| LockHint lock_hint; |
There was a problem hiding this comment.
It seems to me that these fields should be absl::optional<>s, and that the user-level options should not have an "unspecified" state. That is, the one way to not specify an OrderBy/LockHint is not to provide one, rather than having a second way by specifying an "unspecified" one.
3 participants
This change is
This PR does the following:
Emulates the setup in #6103