Skip to content

feat(storage): Link traces between Open and ReadRange traces. #15236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v-pratap merged 8 commits into from
Jun 30, 2025
Merged

feat(storage): Link traces between Open and ReadRange traces. #15236

v-pratap merged 8 commits into from
Jun 30, 2025

Conversation

@v-pratap
Copy link
Contributor

@v-pratap v-pratap commented Jun 26, 2025 •
edited by scotthart
Loading

Linked traces for Open and ReadRange calls and their tests.

Screenshot 2025-06-26 at 3 17 59 PM

This change is Reviewable

@v-pratap v-pratap requested review from a team as code owners June 26, 2025 09:49
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 26, 2025
@v-pratap v-pratap requested a review from bajajneha27 June 26, 2025 10:09
bajajneha27
bajajneha27 previously approved these changes Jun 26, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (05b46d0) to head (09cfa27).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...async/object_descriptor_connection_tracing_test.cc 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15236      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files        2394     2394              
  Lines      215352   215384      +32     
==========================================
+ Hits       200132   200160      +28     
- Misses      15220    15224       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scotthart
scotthart requested changes Jun 26, 2025
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

google/cloud/storage/internal/async/object_descriptor_connection_tracing_test.cc line 134 at r1 (raw file):

                 SpanWithStatus(opentelemetry::trace::StatusCode::kOk),
                 SpanHasInstrumentationScope(), SpanKindIsClient(),
                 SpanHasEvents(

SpanHasEvents calls testing::IsSuperSetOf which is an unordered matcher. In order to model a parent-child relationship between spans, the order of the spans is salient. Instead of SpanHasEvents useSpanEventsAre which calls testing::ElementsAre which is an ordered matcher and verifies the parent-child relationship you're looking to achieve.

@v-pratap v-pratap enabled auto-merge (squash) June 27, 2025 04:34
@v-pratap
Copy link
Contributor Author

v-pratap commented Jun 27, 2025 •
edited
Loading

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

google/cloud/storage/internal/async/object_descriptor_connection_tracing_test.cc line 134 at r1 (raw file):

                 SpanWithStatus(opentelemetry::trace::StatusCode::kOk),
                 SpanHasInstrumentationScope(), SpanKindIsClient(),
                 SpanHasEvents(

SpanHasEvents calls testing::IsSuperSetOf which is an unordered matcher. In order to model a parent-child relationship between spans, the order of the spans is salient. Instead of SpanHasEvents useSpanEventsAre which calls testing::ElementsAre which is an ordered matcher and verifies the parent-child relationship you're looking to achieve.

Done.

scotthart
scotthart reviewed Jun 30, 2025
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @v-pratap)

@v-pratap v-pratap merged commit 81c1d01 into googleapis:main Jun 30, 2025
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotthart scotthart scotthart approved these changes

@bajajneha27 bajajneha27 bajajneha27 left review comments

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-pratap @bajajneha27 @scotthart