feat(storage): Add check for writeHandle before reansforming write_object_spec to append_object_spec #15224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15224 +/- ##
==========================================
- Coverage 92.94% 92.94% -0.01%
==========================================
Files 2394 2394
Lines 215552 215592 +40
==========================================
+ Hits 200345 200382 +37
- Misses 15207 15210 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
v-pratap
force-pushed
the
add-unit-test-fastbyte-03
branch
from
b6b6ff5 to
c298039
Compare
ddelgrosso1
reviewed
Jun 16, 2025
ddelgrosso1
approved these changes
Jun 17, 2025
bajajneha27
approved these changes
Jun 17, 2025
scotthart
reviewed
Jun 17, 2025
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @ddelgrosso1)
google/cloud/storage/internal/async/handle_redirect_error.cc line 28 at r3 (raw file):
for (auto const& rpc_status_detail : rpc_status.details()) { google::storage::v2::BidiWriteObjectRedirectedError error = google::storage::v2::BidiWriteObjectRedirectedError{};
google::storage::v2::BidiWriteObjectRedirectedError error;
Code quote:
google::storage::v2::BidiWriteObjectRedirectedError error =
google::storage::v2::BidiWriteObjectRedirectedError{};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will only allow transformation from write_obejct_spec to append_object_spec when error has write handle, because the failure without write handle needs write_object_spec as input for retry.
This change is