Skip to content

feat(pubsub): add MakeConnection overloads to support regional and locational endpoints #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scotthart merged 7 commits into from
Jun 4, 2025
Merged

feat(pubsub): add MakeConnection overloads to support regional and locational endpoints #15190

scotthart merged 7 commits into from
Jun 4, 2025

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Jun 3, 2025 •
edited
Loading

fixes #15161

This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner June 3, 2025 18:10
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.94%. Comparing base (97361ad) to head (ffb2ab7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/generated_subscription_admin_integration_test.cc 88.88% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15190      +/-   ##
==========================================
+ Coverage   92.92%   92.94%   +0.01%     
==========================================
  Files        2392     2393       +1     
  Lines      215134   215286     +152     
==========================================
+ Hits       199905   200088     +183     
+ Misses      15229    15198      -31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cuiy0006
cuiy0006 previously approved these changes Jun 4, 2025
View reviewed changes
cuiy0006
cuiy0006 reviewed Jun 4, 2025
View reviewed changes
google/cloud/pubsub/internal/defaults.cc
std::move(opts), "", "PUBSUB_EMULATOR_HOST", "", "pubsub.googleapis.com");
std::move(opts), "", "PUBSUB_EMULATOR_HOST", "",
// optional location tag for generating docs
absl::StrCat(location, location.empty() ? "" : "-",
Copy link
Contributor

@cuiy0006 cuiy0006 Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to add #include "google/cloud/internal/absl_str_cat_quiet.h"

@scotthart scotthart enabled auto-merge (squash) June 4, 2025 18:58
@scotthart scotthart merged commit 618fdfa into googleapis:main Jun 4, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cuiy0006 cuiy0006 cuiy0006 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some requests sent to global endpoint when using locational endpoint

2 participants

@scotthart @cuiy0006