Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Jun 2, 2025

part of the work for #15161

I had to also update the generator to spit out a comment tag to direct the markdown generator to recognize the difference between services that require a location and services that optionally allow a location.


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner June 2, 2025 19:30
@product-auto-label product-auto-label bot added the api: cloudresourcemanager Issues related to the Resource Manager API. label Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (28a33ff) to head (0405d75).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
generator/internal/option_defaults_generator.cc 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15189      +/-   ##
==========================================
- Coverage   92.92%   92.92%   -0.01%     
==========================================
  Files        2392     2392              
  Lines      215131   215134       +3     
==========================================
+ Hits       199907   199909       +2     
- Misses      15224    15225       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 97361ad into googleapis:main Jun 2, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudresourcemanager Issues related to the Resource Manager API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants