Skip to content

samples(storage): add the bucket soft delete related tags #15154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddelgrosso1 merged 2 commits into from
May 21, 2025
Merged

samples(storage): add the bucket soft delete related tags #15154

ddelgrosso1 merged 2 commits into from
May 21, 2025

Conversation

@shubham-up-47
Copy link
Contributor

@shubham-up-47 shubham-up-47 commented May 20, 2025 •
edited by scotthart
Loading

Add tags related to the bucket soft delete samples,

  • storage_disable_soft_delete
  • storage_get_soft_delete_policy
  • storage_set_soft_delete_policy

This change is Reviewable

@shubham-up-47 shubham-up-47 requested review from a team as code owners May 20, 2025 10:15
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (7fe2884) to head (028506f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15154   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files        2392     2392           
  Lines      215105   215108    +3     
=======================================
+ Hits       199904   199909    +5     
+ Misses      15201    15199    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented May 20, 2025

@shubham-up-47 looks like you will need to update the commit message to conform to conventional commits.

@shubham-up-47
Copy link
Contributor Author

shubham-up-47 commented May 21, 2025

@shubham-up-47 looks like you will need to update the commit message to conform to conventional commits.

Done.

@shubham-up-47 shubham-up-47 reopened this May 21, 2025
@shubham-up-47 shubham-up-47 enabled auto-merge (squash) May 21, 2025 05:25
@shubham-up-47 shubham-up-47 disabled auto-merge May 21, 2025 06:09
@shubham-up-47 shubham-up-47 enabled auto-merge (squash) May 21, 2025 08:39
@shubham-up-47 shubham-up-47 disabled auto-merge May 21, 2025 09:05
@ddelgrosso1 ddelgrosso1 merged commit 6625d5f into googleapis:main May 21, 2025
88 of 91 checks passed
@shubham-up-47 shubham-up-47 deleted the soft_delete_samples branch May 21, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shubham-up-47 @ddelgrosso1