Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (8539ae8) to head (f2fefd3).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main   #15134      +/-   ##
==========================================
- Coverage   92.93%   92.92%   -0.01%     
==========================================
  Files        2391     2391              
  Lines      214995   214995              
==========================================
- Hits       199795   199792       -3     
- Misses      15200    15203       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Do we not write sample tests?

No, doesn't appear so for C++. The samples usually run as part of the integration tests but I disabled it for these as creating an AnywhereCache takes an extremely long time.

Do we not write sample tests?

No, doesn't appear so for C++. The samples usually run as part of the integration tests but I disabled it for these as creating an AnywhereCache takes an extremely long time.

I see. We should also add the new file in google/cloud/storage/examples/CMakeLists.txt and google/cloud/storage/examples/storage_examples.bzl

Do we not write sample tests?

No, doesn't appear so for C++. The samples usually run as part of the integration tests but I disabled it for these as creating an AnywhereCache takes an extremely long time.

I see. We should also add the new file in google/cloud/storage/examples/CMakeLists.txt and google/cloud/storage/examples/storage_examples.bzl

I don't think we want to do that. If we add storage control samples within storage we would then have to include storage control as a dependency of storage.

Do we not write sample tests?

No, doesn't appear so for C++. The samples usually run as part of the integration tests but I disabled it for these as creating an AnywhereCache takes an extremely long time.

I see. We should also add the new file in google/cloud/storage/examples/CMakeLists.txt and google/cloud/storage/examples/storage_examples.bzl

I don't think we want to do that. If we add storage control samples within storage we would then have to include storage control as a dependency of storage.

Oh yeah, this is storage control. My bad.