-
Notifications
You must be signed in to change notification settings - Fork 433
samples(storage): add samples for soft delete objects #15133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shubham-up-47
merged 11 commits into
googleapis:main
from
shubham-up-47:object_soft_delete
May 15, 2025
Merged
samples(storage): add samples for soft delete objects #15133
shubham-up-47
merged 11 commits into
googleapis:main
from
shubham-up-47:object_soft_delete
May 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d bucket in the tests
ddelgrosso1
reviewed
May 8, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 8, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 8, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 8, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 8, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15133 +/- ##
=======================================
Coverage 92.92% 92.93%
=======================================
Files 2391 2392 +1
Lines 214995 215083 +88
=======================================
+ Hits 199791 199882 +91
+ Misses 15204 15201 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddelgrosso1
reviewed
May 12, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 12, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
reviewed
May 12, 2025
google/cloud/storage/examples/storage_object_soft_delete_samples.cc
Outdated
Show resolved
Hide resolved
ddelgrosso1
approved these changes
May 14, 2025
Contributor
ddelgrosso1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add samples for object soft delete,
This change is