Skip to content

feat(storage): Add integration tests for bidi operations and make ABORTED as retriable error #15114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ddelgrosso1 merged 5 commits into from
Apr 30, 2025
Merged

feat(storage): Add integration tests for bidi operations and make ABORTED as retriable error #15114

ddelgrosso1 merged 5 commits into from
Apr 30, 2025

Conversation

@bajajneha27
Copy link
Contributor

@bajajneha27 bajajneha27 commented Apr 29, 2025 •
edited by scotthart
Loading

This change is Reviewable

@bajajneha27 bajajneha27 requested review from a team as code owners April 29, 2025 11:46
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 29, 2025
@bajajneha27 bajajneha27 added the do not review Indicates a PR is not ready for review label Apr 29, 2025
scotthart
scotthart approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 2 unresolved discussions

google/cloud/storage/async/retry_policy.h line 59 at r1 (raw file):

 * - [`kInternal`](@ref google::cloud::StatusCode)
 * - [`kResourceExhausted`](@ref google::cloud::StatusCode)
 * - [`kUnavailable`](@ref google::cloud::StatusCode)

Add Aborted to this list.

google/cloud/storage/async/retry_policy.h line 109 at r1 (raw file):

 * - [`kInternal`](@ref google::cloud::StatusCode)
 * - [`kResourceExhausted`](@ref google::cloud::StatusCode)
 * - [`kUnavailable`](@ref google::cloud::StatusCode)

Add Aborted to this list.

@codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.29119% with 41 lines in your changes missing coverage. Please review.

Project coverage is 92.95%. Comparing base (c010d41) to head (f7ff49c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...torage/internal/async/writer_connection_resumed.cc 64.19% 29 Missing ⚠️
...oud/storage/tests/async_client_integration_test.cc 92.07% 8 Missing ⚠️
google/cloud/storage/async/retry_policy.h 82.60% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15114      +/-   ##
==========================================
+ Coverage   92.91%   92.95%   +0.03%     
==========================================
  Files        2389     2391       +2     
  Lines      214852   215058     +206     
==========================================
+ Hits       199639   199899     +260     
+ Misses      15213    15159      -54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bajajneha27 bajajneha27 force-pushed the chore-merge-from-prelaunch-circa-2025-04-29 branch from cee016c to 9673e1a Compare April 30, 2025 08:50
@bajajneha27
Copy link
Contributor Author

bajajneha27 commented Apr 30, 2025

@scotthart The GitHub actions have not run even after your approval. Do you know what's missing?

@bajajneha27 bajajneha27 removed the do not review Indicates a PR is not ready for review label Apr 30, 2025
@bajajneha27
Copy link
Contributor Author

bajajneha27 commented Apr 30, 2025

Oh, you probably need to manually approve it for non-cloud-cpp-owners PRs.

@ddelgrosso1 ddelgrosso1 merged commit 685424c into googleapis:main Apr 30, 2025
78 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotthart scotthart scotthart approved these changes

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bajajneha27 @scotthart @ddelgrosso1