feat(storage): Make absl::cord constructor public in write_payload.h #15113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15113 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 2389 2389
Lines 214832 214832
=======================================
+ Hits 199631 199643 +12
+ Misses 15201 15189 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddelgrosso1
approved these changes
Apr 29, 2025
bajajneha27
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously users couldn't call
WritePayloadforabsl::Cordtype. As per feature request #14868, there was a use case where user want to write absl::Cord data directly to GCS. Therefore the made the existing private constructor to a public constructor.This change is