Skip to content

feat(spanner): add spanner::Value support for TypeCode::INTERVAL #15094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scotthart merged 1 commit into from
Apr 25, 2025
Merged

feat(spanner): add spanner::Value support for TypeCode::INTERVAL #15094

scotthart merged 1 commit into from
Apr 25, 2025

Conversation

@devbww
Copy link
Contributor

@devbww devbww commented Apr 16, 2025 •
edited by scotthart
Loading

This change is Reviewable

@devbww devbww requested a review from a team as a code owner April 16, 2025 18:55
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 16, 2025
scotthart
scotthart approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devbww)

@scotthart
Copy link
Member

scotthart commented Apr 18, 2025

/gcbrun

1 similar comment
@scotthart
Copy link
Member

scotthart commented Apr 23, 2025

/gcbrun

@scotthart
Copy link
Member

scotthart commented Apr 23, 2025

/gcbrun

@cuiy0006
Copy link
Contributor

cuiy0006 commented Apr 24, 2025

/gcbrun

@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (7d87eb6) to head (426885d).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/spanner/value.cc 87.50% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15094   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files        2360     2360           
  Lines      211708   211766   +58     
=======================================
+ Hits       196685   196746   +61     
+ Misses      15023    15020    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
Copy link
Member

scotthart commented Apr 25, 2025

/gcbrun

@scotthart scotthart merged commit 440dcd6 into googleapis:main Apr 25, 2025
78 of 79 checks passed
@devbww devbww deleted the interval branch April 25, 2025 16:36
devbww added a commit to devbww/google-cloud-cpp that referenced this pull request Apr 25, 2025
@devbww
feat(spanner): add spanner::Value support for TypeCode::INTERVAL (goo…
37af5a0 
…gleapis#15094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotthart scotthart scotthart approved these changes

+1 more reviewer

@cuiy0006 cuiy0006 cuiy0006 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devbww @scotthart @cuiy0006