-
Notifications
You must be signed in to change notification settings - Fork 433
feat: add option to allow setting CURLOPT_INTERFACE #15044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions
google/cloud/internal/curl_options.h line 135 at r1 (raw file):
* Sets the interface name to use as outgoing network interface. * * The default is to use whatever the TCP stack finds suitable.
Additionally, we may want to indicate that there's some formatting conventions available for the string per https://curl.se/libcurl/c/CURLOPT_INTERFACE.html
google/cloud/internal/curl_options.h line 137 at r1 (raw file):
* The default is to use whatever the TCP stack finds suitable. */ struct Interface {
I'm assuming we want users to set this directly, so let's move this from the "internal" curl_options.h to google/cloud/rest_options.h.
ddelgrosso1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @scotthart)
google/cloud/internal/curl_options.h line 135 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
Additionally, we may want to indicate that there's some formatting conventions available for the string per https://curl.se/libcurl/c/CURLOPT_INTERFACE.html
Done.
google/cloud/internal/curl_options.h line 137 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
I'm assuming we want users to set this directly, so let's move this from the "internal" curl_options.h to google/cloud/rest_options.h.
Done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15044 +/- ##
==========================================
- Coverage 92.90% 92.90% -0.01%
==========================================
Files 2351 2351
Lines 210211 210224 +13
==========================================
+ Hits 195297 195301 +4
- Misses 14914 14923 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ddelgrosso1)
|
/gcbrun |
This change is