Skip to content

fix(common): support libc++ >= 18.1#14151

Merged
alevenberg merged 3 commits intogoogleapis:mainfrom
coryan:fix-common-future-error-workaround
May 7, 2024
Merged

fix(common): support libc++ >= 18.1#14151
alevenberg merged 3 commits intogoogleapis:mainfrom
coryan:fix-common-future-error-workaround

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented May 7, 2024

Starting with libc++ 18.1 the std::future_error(future_errc)
constructor only appears if compiling with C++17.

Part of the work for #14076


This change is Reviewable

Starting with libc++ 18.1 the `std::future_error(future_errc)`
constructor only appears if compiling with C++17.
@alevenberg alevenberg marked this pull request as ready for review May 7, 2024 16:54
@alevenberg alevenberg requested a review from a team May 7, 2024 16:54
@alevenberg alevenberg enabled auto-merge (squash) May 7, 2024 16:54
@alevenberg alevenberg merged commit 88a9754 into googleapis:main May 7, 2024
@coryan coryan deleted the fix-common-future-error-workaround branch May 7, 2024 17:43
veblush added a commit to veblush/grpc that referenced this pull request May 22, 2024
veblush added a commit to veblush/grpc that referenced this pull request May 23, 2024
veblush added a commit to veblush/grpc that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants