Separate Docker image creation vs. build. #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly to measure how long each phase takes, to guide any future optimization of the builds, such as caching. It fixes googleapis#49.
googlebot
added
the
cla: yes
mbrukman
suggested changes
Dec 22, 2017
CONTRIBUTING.md
Outdated
| * `DISTRO_VERSION`: the version of the distribution, e.g. `17.04`. | ||
| * `CHECK_STYLE`: if set to `yes` the build fails if the code is different | ||
| than the output from `clang-format(1)`. | ||
| than the output from `clang-format(1)`. Notice that this reformats your |
CONTRIBUTING.md
Outdated
| * `CXX=g++ CC=gcc` to use GCC. | ||
| * `DISTRO`: the Linux distribution, use `ubuntu`, `fedora`, or `centos`. | ||
| * `DISTRO_VERSION`: the version of the distribution, e.g. `17.04`. | ||
| * `CHECK_STYLE`: if set to `yes` the build fails if the code is different |
Contributor
There was a problem hiding this comment.
s/ the build/, the build/
ci/build-docker.sh
Outdated
| mkdir -p gccpp/build-output | ||
| cd gccpp/build-output | ||
| readonly IMAGE="cached-${DISTRO}-${DISTRO_VERSION}" | ||
| mkdir -p build-output/${IMAGE} |
ci/build-docker.sh
Outdated
| cd gccpp/build-output | ||
| readonly IMAGE="cached-${DISTRO}-${DISTRO_VERSION}" | ||
| mkdir -p build-output/${IMAGE} | ||
| cd build-output/${IMAGE} |
| ${CMAKE_COMMAND} -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" ${CMAKE_FLAGS:-} .. | ||
|
|
||
| # If scan-build is enabled we, need to manually compile the dependencies; | ||
| echo "travis_fold:start:configure-cmake" |
Contributor
There was a problem hiding this comment.
Does Travis actually understand that as a directive and this is how it adds those collapsible sections?
Contributor
Author
There was a problem hiding this comment.
Yes, for example see:
It is sort of documented or officially not documented in travis-ci/travis-ci#2285
ci/build-docker.sh
Outdated
| # needed; otherwise, we pick errors from things we do not care about. With | ||
| # scan-build disabled we compile everything, to test the build as most | ||
| # developers will experience it. | ||
| echo ${COLOR_YELLOW}"Started build at: " $(date) ${COLOR_RESET} |
ci/build-docker.sh
Outdated
| else | ||
| make -j ${NCPU} all | ||
| fi | ||
| echo ${COLOR_YELLOW}"Finished build at: " $(date) ${COLOR_RESET} |
ci/build-docker.sh
Outdated
| _EOF_ | ||
| exit 1 | ||
| else | ||
| echo ${COLOR_GREEN}"scan-build completed without errors."${COLOR_RESET} |
Contributor
There was a problem hiding this comment.
Include the vars inside the string.
ci/build-docker.sh
Outdated
| run scan-build locally and examine the HTML output install and configure Docker, | ||
| then run:" | ||
| DISTRO=ubuntu DISTRO_VERSION=17.04 SCAN_BUILD=yes NCPU=8 TRAVIS_OS_NAME=linux CXX=clang++ CC=clang ./ci/build-linux.sh" |
Contributor
There was a problem hiding this comment.
Why the quote at EOL, if you are outputting all text until _EOF_?
Contributor
Author
There was a problem hiding this comment.
That was just a cut&paste / editing mistake.
ci/build-docker.sh
Outdated
| DISTRO=ubuntu DISTRO_VERSION=17.04 SCAN_BUILD=yes NCPU=8 TRAVIS_OS_NAME=linux CXX=clang++ CC=clang ./ci/build-linux.sh" | ||
| The HTML output will be copied into the scan-build-output subdirectory." |
Contributor
There was a problem hiding this comment.
Why the quote at EOL, if you are outputting all text until _EOF_?
Contributor
Author
|
PTAL. |
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Dec 28, 2017
The documents are generated inside a docker image, in a previous change (googleapis#138), the path for the generated docs was changed. This script should have been changed at the same time. While testing I found out that there was another tiny problem, the documents were never uploaded because the change detection was broken. Fix that too <blush>.
coryan
added a commit
that referenced
this pull request
Dec 30, 2017
The documents are generated inside a docker image, in a previous change (#138), the path for the generated docs was changed. This script should have been changed at the same time. While testing I found out that there was another tiny problem, the documents were never uploaded because the change detection was broken. Fix that too <blush>.
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Jan 8, 2018
mbrukman
pushed a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to measure how long each phase takes, to guide any
future optimization of the builds, such as caching. It fixes #49.