refactor(bigtable): make bigtable_mocks header only #13546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13546 +/- ##
=======================================
Coverage 93.18% 93.18%
=======================================
Files 2195 2195
Lines 190874 190874
=======================================
Hits 177867 177867
Misses 13007 13007 ☔ View full report in Codecov by Sentry. |
alevenberg
approved these changes
Feb 2, 2024
scotthart
approved these changes
Feb 2, 2024
Member
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dbolduc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #5782
For some reason CMake complains when we export
google_cloud_cpp_bigtable_mocksbecause it cannot find the linked library:GTest::gmock_main. This problem does not come up with interface (header only) libraries.We want to always install the mocks.... but we also do not want to
Find(GTest)whenNOT BUILD_TESTING.... so this is my solution to unblock installing the mocks library for bigtable.This change is