Skip to content

impl(bigtable): support bigtable cookie in AsyncBulkApply#13481

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:bigtable-retry-context-async-bulk-apply
Jan 19, 2024
Merged

impl(bigtable): support bigtable cookie in AsyncBulkApply#13481
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:bigtable-retry-context-async-bulk-apply

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Jan 19, 2024

Fixes #13447

Very similar to #13479...


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 19, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2ded42) 93.11% compared to head (896168b) 93.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13481   +/-   ##
=======================================
  Coverage   93.11%   93.12%           
=======================================
  Files        2183     2183           
  Lines      190200   190251   +51     
=======================================
+ Hits       177112   177169   +57     
+ Misses      13088    13082    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review January 19, 2024 17:33
@dbolduc dbolduc requested a review from a team January 19, 2024 17:33
Copy link
Copy Markdown
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit f93fc82 into googleapis:main Jan 19, 2024
@dbolduc dbolduc deleted the bigtable-retry-context-async-bulk-apply branch January 19, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bigtable routing cookies

2 participants