impl(bigtable): support bigtable cookie in AsyncSampleRows#13479
Merged
dbolduc merged 2 commits intogoogleapis:mainfrom Jan 19, 2024
Merged
impl(bigtable): support bigtable cookie in AsyncSampleRows#13479dbolduc merged 2 commits intogoogleapis:mainfrom
AsyncSampleRows#13479dbolduc merged 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: bigtable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13479 +/- ##
=======================================
Coverage 93.11% 93.12%
=======================================
Files 2183 2183
Lines 190200 190245 +45
=======================================
+ Hits 177112 177160 +48
+ Misses 13088 13085 -3 ☔ View full report in Codecov by Sentry. |
alevenberg
reviewed
Jan 19, 2024
| timer_promise.set_value(make_status_or(std::chrono::system_clock::now())); | ||
| } | ||
|
|
||
| TEST_F(AsyncSampleRowKeysTest, BigtableCookie) { |
Contributor
There was a problem hiding this comment.
Maybe add a comment saying the validation happens in the metadata fixture? It kind of makes it hard to see what the test is doing
Member
Author
There was a problem hiding this comment.
Added clarifying comments which should draw the reader's eye.
alevenberg
approved these changes
Jan 19, 2024
This was referenced Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work for #13447
Again, we need to hold onto the
grpc::ClientContext. Reset the ptr when we are done with it.Note that only tests that retry need the
metadata_fixture_.SetServerMetadata(...)treatment.This change is