Use default move assignment and move constructor. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new grpc introduced in googleapis#86 we got protobuf 3.4.x which also has move constructor and assignment for generated protos. That means we can use the default move constructor in the Filter class.
googlebot
added
the
cla: yes
bajajneha27
pushed a commit
to bajajneha27/google-cloud-cpp
that referenced
this pull request
Apr 29, 2025
bajajneha27
pushed a commit
to bajajneha27/google-cloud-cpp
that referenced
this pull request
Apr 30, 2025
ddelgrosso1
added a commit
that referenced
this pull request
Apr 30, 2025
…RTED as retriable error (#15114) * chore(ACv2): Add integration tests for fastbyte operations (#115) * feat: Make ABORTED as retriable error (#116) * test failure fix and address review comments * Improve some internal documentation * checkers-pr fix --------- Co-authored-by: Denis DelGrosso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new grpc introduced in #86 we got protobuf 3.4.x which
also has move constructor and assignment for generated protos.
That means we can use the default move constructor in the Filter
class.