Skip to content

Audit use of pre-computed hashes for uploads and downloads #7014

Closed
#7025
Closed
Audit use of pre-computed hashes for uploads and downloads#7014
#7025
Assignees
coryan
Labels
api: storageIssues related to the Cloud Storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@coryan

Description

@coryan
coryan
opened on Jul 17, 2021

After implementing the changes for #4156 and #4157 I am not convinced that the existing uses of Crc32cChecksumValue() and MD5HashValue() work correctly.

We need to review the existing unit and integration tests, and verify they are passing for the right reasons. If needed, we need to write new integration tests.

Labeled as cleanup for now, but if the audit reveals a problem then we should change the type of this issue to a p1 bug.

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the Cloud Storage API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions