Disable tests that depend on checksum validation

coryan · coryan · commit f1f5f9243482 · 2021-07-09T19:23:06.000Z
diff --git a/google/cloud/storage/tests/object_checksum_integration_test.cc b/google/cloud/storage/tests/object_checksum_integration_test.cc
@@ -93,6 +93,8 @@ TEST_F(ObjectChecksumIntegrationTest, XmlInsertWithCrc32c) {
 }
 
 TEST_F(ObjectChecksumIntegrationTest, InsertWithCrc32cFailure) {
+  // TODO(#4156) - use the MD5 hashes
+  if (UsingGrpc()) GTEST_SKIP();
   StatusOr<Client> client = MakeIntegrationTestClient();
   ASSERT_STATUS_OK(client);
 
@@ -108,6 +110,8 @@ TEST_F(ObjectChecksumIntegrationTest, InsertWithCrc32cFailure) {
 }
 
 TEST_F(ObjectChecksumIntegrationTest, XmlInsertWithCrc32cFailure) {
+  // TODO(#4156) - use the MD5 hashes
+  if (UsingGrpc()) GTEST_SKIP();
   StatusOr<Client> client = MakeIntegrationTestClient();
   ASSERT_STATUS_OK(client);
 
diff --git a/google/cloud/storage/tests/object_hash_integration_test.cc b/google/cloud/storage/tests/object_hash_integration_test.cc
@@ -280,6 +280,8 @@ TEST_F(ObjectHashIntegrationTest, VerifyValidMD5StreamingWriteJSON) {
 
 /// @test Verify invalid MD5 hash value before upload.
 TEST_F(ObjectHashIntegrationTest, InvalidMD5StreamingWriteJSON) {
+  // TODO(#4157) - use the MD5 hashes
+  if (UsingGrpc()) GTEST_SKIP();
   StatusOr<Client> client = MakeIntegrationTestClient();
   ASSERT_STATUS_OK(client);
 
@@ -302,6 +304,8 @@ TEST_F(ObjectHashIntegrationTest, InvalidMD5StreamingWriteJSON) {
 
 /// @test Verify MD5 hashes before upload.
 TEST_F(ObjectHashIntegrationTest, InvalidMD5StreamingWriteXML) {
+  // TODO(#4157) - use the MD5 hashes
+  if (UsingGrpc()) GTEST_SKIP();
   StatusOr<Client> client = MakeIntegrationTestClient();
   ASSERT_STATUS_OK(client);
 
@@ -324,6 +328,8 @@ TEST_F(ObjectHashIntegrationTest, InvalidMD5StreamingWriteXML) {
 
 /// @test Verify that hashes and checksums can be disabled in uploads.
 TEST_F(ObjectHashIntegrationTest, DisableHashesStreamingWriteJSON) {
+  // TODO(#4157) - use the MD5 hashes
+  if (UsingGrpc()) GTEST_SKIP();
   StatusOr<Client> client = MakeIntegrationTestClient();
   ASSERT_STATUS_OK(client);
 

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,8 @@ TEST_F(ObjectChecksumIntegrationTest, XmlInsertWithCrc32c) {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`TEST_F(ObjectChecksumIntegrationTest, InsertWithCrc32cFailure) {`
	`96`	`+ // TODO(#4156) - use the MD5 hashes`
	`97`	`+ if (UsingGrpc()) GTEST_SKIP();`
`96`	`98`	`StatusOr<Client> client = MakeIntegrationTestClient();`
`97`	`99`	`ASSERT_STATUS_OK(client);`
`98`	`100`
`@@ -108,6 +110,8 @@ TEST_F(ObjectChecksumIntegrationTest, InsertWithCrc32cFailure) {`
`108`	`110`	`}`
`109`	`111`
`110`	`112`	`TEST_F(ObjectChecksumIntegrationTest, XmlInsertWithCrc32cFailure) {`
	`113`	`+ // TODO(#4156) - use the MD5 hashes`
	`114`	`+ if (UsingGrpc()) GTEST_SKIP();`
`111`	`115`	`StatusOr<Client> client = MakeIntegrationTestClient();`
`112`	`116`	`ASSERT_STATUS_OK(client);`
`113`	`117`