Skip to content

tests: fix unit tests on python 3.6 / 3.7 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
busunkim96 merged 2 commits into from
Oct 22, 2020
Merged

tests: fix unit tests on python 3.6 / 3.7 #630

busunkim96 merged 2 commits into from
Oct 22, 2020

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 22, 2020

Closes #629.

@tseaver tseaver requested a review from a team as a code owner October 22, 2020 19:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@busunkim96 busunkim96 merged commit 3b3172e into master Oct 22, 2020
@davidwtbuxton davidwtbuxton mentioned this pull request Oct 22, 2020
Merged
@tseaver tseaver deleted the 629-fix-tests-py36-py37 branch October 23, 2020 01:55
@tseaver tseaver mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests broken on Python < 3.8

2 participants

@tseaver @busunkim96