fix: avoid losing the original _include_email parameter in impersonated credentials #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tseaver
suggested changes
Oct 28, 2020
Contributor
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
PR needs new unit tests / assertions to verify that the includ_email value is propagated.
Contributor
Author
|
@tseaver the unit tests are updated and I checked that they are red without the fix, and green with the fix. |
Contributor
Author
|
It seems that Conventional Commits is complaining about a commit message that I didn't include. Weird. |
busunkim96
changed the title
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
@pietrodn lint is failing. Please run |
Fix on the Impersonated Credentials class. In IDTokenCredentials.with_target_audience(), IDTokenCredentials.from_credentials(), don't discard the original self._include_email parameter.
Contributor
Author
|
@tseaver reformatted and rebased. ✅ |
tseaver
added
the
kokoro:force-run
tseaver
approved these changes
Dec 11, 2020
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
@pietrodn Thanks for your persistence! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.24.0](https://www.github.com/googleapis/google-auth-library-python/compare/v1.23.0...v1.24.0) (2020-12-11) ### Features * add Python 3.9 support, drop Python 3.5 support ([#655](https://www.github.com/googleapis/google-auth-library-python/issues/655)) ([6de753d](https://www.github.com/googleapis/google-auth-library-python/commit/6de753d585254c813b3e6cbde27bf5466261ba10)), closes [#654](https://www.github.com/googleapis/google-auth-library-python/issues/654) ### Bug Fixes * avoid losing the original '_include_email' parameter in impersonated credentials ([#626](https://www.github.com/googleapis/google-auth-library-python/issues/626)) ([fd9b5b1](https://www.github.com/googleapis/google-auth-library-python/commit/fd9b5b10c80950784bd37ee56e32c505acb5078d)) ### Documentation * fix typo in import ([#651](https://www.github.com/googleapis/google-auth-library-python/issues/651)) ([3319ea8](https://www.github.com/googleapis/google-auth-library-python/commit/3319ea8ae876c73a94f51237b3bbb3f5df2aef89)), closes [#650](https://www.github.com/googleapis/google-auth-library-python/issues/650) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
IDTokenCredentials.with_target_audience(),IDTokenCredentials.from_credentials(), don't discard the originalself._include_emailparameter of the original credentials instance.